Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article::doEdit() dropped in MW 1.29 (deprecated in 1.21) #31

Closed
reedy opened this issue Dec 11, 2016 · 4 comments
Closed

Article::doEdit() dropped in MW 1.29 (deprecated in 1.21) #31

reedy opened this issue Dec 11, 2016 · 4 comments

Comments

@reedy
Copy link

reedy commented Dec 11, 2016

https://gerrit.wikimedia.org/r/#/c/326326/ was made by a GCI student, if you want to import it to this repo
@feelfreelinux
Copy link

feelfreelinux commented Dec 11, 2016 •
edited
Loading

I made this for GCI
Should i make pull request?

@samuell
Copy link
Member

samuell commented Dec 12, 2016

@feelfreelinux Absolutely, feel free to send a pull request! Just please base it off of this repo's current version of SMWPageWriter, as there is probably quite some substantial changes made to this repo after the one in the MW repo, which is very outdated.

But if you send a PR, we can discuss any minor issues in the PR, after I have checked it.

@samuell
Copy link
Member

samuell commented Aug 2, 2017

Just a note for the record that Article::doEdit() was finally dropped in MW 1.29, as stated in the release notes.

@samuell samuell changed the title Article::doEdit() is deprecated Article::doEdit() dropped in MW 1.29 (deprecated in MW 1.21) Aug 2, 2017
@samuell samuell changed the title Article::doEdit() dropped in MW 1.29 (deprecated in MW 1.21) Article::doEdit() dropped in MW 1.29 (deprecated in 1.21) Aug 2, 2017
samuell added a commit that referenced this issue Aug 9, 2017
@samuell
Implementing gerrit.wikimedia.org/r/#/c/326326 to remove use of depre…
6abe207 
…cated doEdit() closing #31
samuell added a commit that referenced this issue Aug 9, 2017
@samuell
Implementing gerrit.wikimedia.org/r/#/c/326326 by @feelfreelinux to r…
6c7c834 
…emove use of deprecated doEdit() closing #31
samuell added a commit that referenced this issue Aug 9, 2017
@samuell
Implementing gerrit.wikimedia.org/r/#/c/326326 by @feelfreelinux to r…
3826d19 
…emove use of deprecated doEdit() fixing #31
@samuell
Copy link
Member

samuell commented Aug 9, 2017

Thanks tons, @feelfreelinux , implemented now!

@samuell samuell closed this as completed Aug 9, 2017
@thiviyanT thiviyanT mentioned this issue Nov 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reedy @samuell @feelfreelinux