Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config to find fuse libraries #5

Merged
merged 1 commit into from Mar 25, 2021

Conversation

ardovm
Copy link
Contributor

@ardovm ardovm commented Mar 23, 2021

Should allow building on modern Linux hosts (partially fix of issue #4)

Please note that this is my own work, and is not based on the Debian package patches.
(I read about the Debian package just after committing this)
Integrating the other patches from the Debian package is beyond my current purposes, and could be a possibly better alternative than merging this PR.

Should allow building on modern Linux hosts (partially fix of issue rdiff-backup#4)
@ericzolf
Copy link
Member

My suggestion:

Opinions?

@ericzolf
Copy link
Member

I meant (of course) @anotherMuppet (sorry!)

Copy link

@anotherMuppet anotherMuppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can confirm compilation and mounting a repository results in correct file sizes for large files without i/o errors

@anotherMuppet
Copy link

anotherMuppet commented Mar 25, 2021

i'm not sure how to reward you the $30 on bountysource, @ardovm

i think @ericzolf has to claim ownership of the project on bountysource and then myself or him can award you

@ardovm
Copy link
Contributor Author

ardovm commented Mar 25, 2021

That's very kind of you... but do not worry. There is no urgency.

@anotherMuppet
Copy link

@ericzolf can you claim ownership of the rdiff-backup team on bountysource? https://www.bountysource.com/issues/96838952-files-with-a-byte-size-larger-than-an-int-cause-i-o-errors

i can't seem to navigate that particular site very well, and google isn't much help (nor is their documentation)

@anotherMuppet
Copy link

actually, @ardovm i think you need to visit the above link and click "solve issue" and then claim it, then i can reject or approve it

afaik there's nothing you need to do @ericzolf

@ardovm
Copy link
Contributor Author

ardovm commented Mar 25, 2021

@anotherMuppet I did. I had to indicate a pull request and I indicated this one, because the previous PR #4 was already closed and, in fact, did not completely solve the problem (the code did not build).

So, maybe, merging this PR should be the next step in order to assign the bounty.

As I already wrote, I am not in a hurry. If there are other changes that you would like merged into the code, please tell me and I will update this PR. When all of you will be satisfied, we will merge it and proceed further.

@anotherMuppet
Copy link

@ardovm i've lodged a support ticket with bountysource, hopefully they'll get back to me soon

also of note, i think bountysource charges a 10% fee on withdrawals, so that's reduced it to $27

i'll leave it up to @ericzolf to do the merging, etc.

@anotherMuppet
Copy link

@ardovm support just got back to me and said it was due to a sync issue, you can now claim the bounty https://www.bountysource.com/issues/96838952-files-with-a-byte-size-larger-than-an-int-cause-i-o-errors

@ericzolf
Copy link
Member

As a said that I'll merge once @anotherMuppet confirms, I merge. Thanks for this, it was fun!

@ericzolf ericzolf merged commit ac43bc9 into rdiff-backup:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants