Fixing Program/BlockStatement rewrites #100
Conversation
| @@ -40,7 +67,7 @@ describe('jsfmt.rewrite', function() { | |||
|
|
|||
| // Inside of "BlockStatement" instead of "Program" | |||
| jsfmt.rewrite('function test() { var myA = 1, myB = 2; }', 'var a = c, b = d; -> var a = c; var b = d;') | |||
| .toString().should.eql('function test() {\n var myA = 1;\n var myB = 2;\n}'); | |||
| .toString().should.eql('function test() { var myA = 1;\nvar myB = 2; }'); | |||
There was a problem hiding this comment.
this doesn't seem exactly right:
function test() { var myA = 1, myB = 2; }gets rewritten to:
function test() { var myA = 1;
var myB = 2; }is this the actual expected? I would assume it shouldn't get the newline?
There was a problem hiding this comment.
Hmm, yah. So, what happens now is that when rewriting it only mangles the matched expressions, without context. So only the matched expressions will be formatted, post-rewrite. It may make sense to explicitly re-format the entire output. What do you think?
There was a problem hiding this comment.
well, we do that now dont we with rewriting? it'll reformat unless you give --no-format?
There was a problem hiding this comment.
Hmm, good point. So this is just the raw output from the rewrite before the formatting has been applied.
There was a problem hiding this comment.
which actually might be ok, since we dont intend on testing formatting here, we want to test rewrite.
|
Unfortunately I haven't had the time to delve into this (I think its at least a day of work to sort it out). Some thoughts:
|
|
Needs a rewrite. |
Fixes #90
There is one failing test I haven't figured out how to fix yet. We need to unwrap
ExpressionStatementsfor the general case but here if we don't then we end up with two semicolons.