convert format to use regex replace for shebangs #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indexOf will parse the entire string for `#1` while regex for beginning of string will fail-short if first chars don't match. - Performance boost (more than 50% on large strings) - Cleaner syntax
|
unfortunately the shebang removal/etc happens in more than 1 place. EDIT: have been meaning to look at refactoring it, wouldn't be hurt if you wanted to do it :) also can you add tests for the edge cases where the previous way falls short? |
|
Previous way doesn't have a fail case, but if you don't have a shebang in start of string, the indexOf is going to scan the entire string for it. Just extract what I wrote to an external helper function... edit I'll do the refactoring... It's going to move to an external lib I guess |
|
@pgilad ah, yes you are right... it does. :( silly me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexOf will parse the entire string for
#1while regex for beginning of string will fail-short if first chars don't match.