Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shebangs usage to helper lib #88

Merged
merged 4 commits into from
Jun 25, 2014
Merged

refactor shebangs usage to helper lib #88

merged 4 commits into from
Jun 25, 2014

Conversation

pgilad
Copy link
Contributor

@pgilad pgilad commented Jun 25, 2014

No description provided.

@pgilad
convert format to use regex replace for shebangs
86cf387 
indexOf will parse the entire string for `#1` while regex for beginning of string will fail-short if first chars don't match.

- Performance boost (more than 50% on large strings)
- Cleaner syntax
@pgilad
Extract shebang functions to external lib
2cbfd9a
@coveralls
Copy link

Coverage Status

Coverage increased (+0.45%) when pulling 2cbfd9a on pgilad:origin/patch-1 into 0fb7b16 on rdio:master.

@brettlangdon
Copy link
Contributor

THANKS!

can you just run grunt fmt since it looks like you are using 4 spaces and the project is using 2.

@brettlangdon
Copy link
Contributor

quick response, love it.

👍

@pgilad
Copy link
Contributor Author

pgilad commented Jun 25, 2014

Yeah I'm used to .editorconfig and .jshintrc to automatically do this for me (but missing in this project)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.45%) when pulling 2e1465a on pgilad:origin/patch-1 into 0fb7b16 on rdio:master.

@jimfleming
Copy link
Contributor

Looks good to me. One more nit, SheBang => Shebang. Its just one word (http://en.wikipedia.org/wiki/Shebang_(Unix)) :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.45%) when pulling 60abc1f on pgilad:origin/patch-1 into 0fb7b16 on rdio:master.

@jimfleming
Copy link
Contributor

👍

jimfleming added a commit that referenced this pull request Jun 25, 2014
@jimfleming
Merge pull request #88 from pgilad/origin/patch-1
adc0b95 
refactor shebangs usage to helper lib
@jimfleming jimfleming merged commit adc0b95 into rdio:master Jun 25, 2014
@pgilad pgilad deleted the origin/patch-1 branch June 25, 2014 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pgilad @coveralls @brettlangdon @jimfleming