Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use esformatter-braces plugin by default #99

Merged
merged 2 commits into from
Jul 21, 2014

Conversation

brettlangdon
Copy link
Contributor

this is in regards to #91 on handling of single line if statements.

all this needs left is to run grunt fmt on the source, but it is blocked by #98 which I have not been able to dig into much further.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 86f3c54 on brettlangdon:braces into e4c9b5e on rdio:master.

jimfleming added a commit that referenced this pull request Jul 21, 2014
use esformatter-braces plugin by default
@jimfleming jimfleming merged commit 358532a into rdio:master Jul 21, 2014
@jimfleming
Copy link
Contributor

Looks good, thanks!

@jimfleming
Copy link
Contributor

I might have time to look into #98 today — I can run grunt fmt with that PR when its ready.

@brettlangdon
Copy link
Contributor Author

@jimfleming awesome

also, I didn't expect you to merge yet, having issues with #98 and running jsfmt on style guide and source, etc

@brettlangdon brettlangdon deleted the braces branch July 21, 2014 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants