Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDK-34246 : Increase Dobby Test Coverage #190

Closed
wants to merge 12 commits into from
Closed

Conversation

ks734
Copy link
Contributor

@ks734 ks734 commented Apr 6, 2022

Description

What does this PR change/fix and why?

If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.

Test Procedure

How to test this PR (if applicable)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@TeknoVenus TeknoVenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the PR description to replace the placeholder text

gtest/DobbyUtilsTest/CMakeLists.txt Outdated Show resolved Hide resolved
gtest/DobbyUtilsTest/tests/ContainerIdTest.cpp Outdated Show resolved Hide resolved
gtest/DobbyUtilsTest/tests/ContainerIdTest.cpp Outdated Show resolved Hide resolved
gtest/DobbyUtilsTest/tests/DobbyUtilsTest.cpp Outdated Show resolved Hide resolved
gtest/DobbyUtilsTest/tests/DobbyUtilsTest.cpp Outdated Show resolved Hide resolved
gtest/DobbyUtilsTest/tests/DobbyUtilsTest.cpp Outdated Show resolved Hide resolved
gtest/DobbyUtilsTest/tests/ContainerIdTest.cpp Outdated Show resolved Hide resolved
@TeknoVenus TeknoVenus added the enhancement New feature or request label Apr 7, 2022
@ks734 ks734 requested a review from TeknoVenus April 8, 2022 06:18
@TeknoVenus TeknoVenus requested a review from Koczek9 April 8, 2022 10:27

if (loopDevFd < 0)
{
printf("failed to open loop device\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace printf() calls with AI_LOG macros

@ks734 ks734 closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants