Merge pull request #402 from rdkcentral/release/5.4.1

Release/5.4.1
rdkcentral · Aug 30, 2023 · 9055aa2 · 9055aa2
2 parents 01e0ab8 + 9f03587
commit 9055aa2
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## v5.4.1
+
+*30 aug 2023*
+
+- Hot fix for the issue observe on even listeners cleanup
+
 ## v5.4.0
 
 *27 jul 2023*

diff --git a/docs/changelog.md b/docs/changelog.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## v5.4.1
+
+*30 aug 2023*
+
+- Hot fix for the issue observe on even listeners cleanup
+
 ## v5.4.0
 
 *27 jul 2023*

diff --git a/docs/package.json b/docs/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/sdk",
-  "version": "5.4.0",
+  "version": "5.4.1",
   "license": "Apache-2.0",
   "types": "index.d.ts",
   "scripts": {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/sdk",
-  "version": "5.4.0",
+  "version": "5.4.1",
   "license": "Apache-2.0",
   "types": "index.d.ts",
   "scripts": {

diff --git a/src/Registry/index.js b/src/Registry/index.js
@@ -138,8 +138,8 @@ export default {
       })
       // remove reference to the target when target has no event listeners registered
       if (Object.keys(registry.eventListeners[targetIndex]).length === 0) {
-        registry.targets.splice(targetIndex)
-        registry.eventListeners.splice(targetIndex)
+        registry.targets.splice(targetIndex, 1)
+        registry.eventListeners.splice(targetIndex, 1)
       }
     } else {
       Log.error(