Fix Stepper errors and fireAncestors augmentation #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-weindel
force-pushed
the
fix-stepper-errors
branch
from
a537222
to
0740869
Compare
frank-weindel
force-pushed
the
fix-stepper-errors
branch
from
0740869
to
90d4f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow the TemplateSpec of Stepper to be extended by subclasses we have to make Stepper generic and allow the extended TemplateSpec to be passed through (see Subclassable Components)
See the
@privateRemarksfor more details on the more advance things that had to be tweaked.I also removed all
anys from Stepper/ArrowStepper/ProgressStepper