Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json Invalid exports definition for commonjs require key #434

Closed
frank-weindel opened this issue Dec 6, 2022 · 0 comments · Fixed by #435 or #448
Closed

package.json Invalid exports definition for commonjs require key #434

frank-weindel opened this issue Dec 6, 2022 · 0 comments · Fixed by #435 or #448
Assignees

Comments

@frank-weindel
Copy link
Collaborator

package.json currently has the "types" and "default" keys swapped for the require key in the main exports definition.

  "exports": {
    ".": {
      "import": {
        "types": "./index.d.ts",
        "default": "./index.js"
      },
      "require": {
        "types": "./dist/lightning.js", // <-- Needs to go to "default"
        "default": "./index.d.ts" // <-- Needs to go to "types"
      }
    }
  },

This is seemingly causing an issue reported by a user on our forums.

@frank-weindel frank-weindel self-assigned this Dec 6, 2022
frank-weindel added a commit to frank-weindel/Lightning that referenced this issue Dec 6, 2022
@uguraslan uguraslan mentioned this issue Feb 7, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant