Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate _cleanupLookupMap call #532

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Remove duplicate _cleanupLookupMap call #532

merged 1 commit into from
Jun 4, 2024

Conversation

jorge-graca-sky
Copy link
Contributor

@uguraslan uguraslan linked an issue Apr 17, 2024 that may be closed by this pull request
Duplicate call for _cleanupLookupMap #520
Closed
frank-weindel
frank-weindel approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@frank-weindel frank-weindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering its running _cleanupLookupMap() synchronously twice back-to-back, and that what _cleanupLookupMap() is doing appears idempotent, it should be safe to remove this duplicate call.

wouterlucas
wouterlucas approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@wouterlucas wouterlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@uguraslan uguraslan changed the base branch from master to dev June 4, 2024 09:20
@uguraslan uguraslan merged commit fff253b into rdkcentral:dev Jun 4, 2024
3 checks passed
@uguraslan uguraslan mentioned this pull request Jun 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterlucas wouterlucas wouterlucas approved these changes

@jfboeve jfboeve jfboeve approved these changes

@frank-weindel frank-weindel frank-weindel approved these changes

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

@michielvandergeest michielvandergeest Awaiting requested review from michielvandergeest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate call for _cleanupLookupMap
5 participants
@jorge-graca-sky @wouterlucas @jfboeve @frank-weindel @uguraslan