[DOC] Singletons section #1540
Merged
[DOC] Singletons section #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MFransen69
requested changes
Mar 6, 2024
docs/utils/singletons.md
Outdated
| @@ -0,0 +1,43 @@ | |||
| ## Using and disposing singletons | |||
There was a problem hiding this comment.
Think it would be good to (very briefly) also describe the use of singletons in Thunder (what they are) and as section on the code in Core we have to help write singletons (e.g. SingletonType, the role of Core::Singleton::Dispose() etc.) and perhaps some small code example. If you have question on this I think Sebastion will be able to provide some details)
MFransen69
approved these changes
Jun 20, 2024
msieben
pushed a commit
that referenced
this pull request
Jun 21, 2024
* singleton section added * singletons documentation section added * singletons.md added to mkdocs.yml * warning fixed * formating fix * singletons description addded * [doc] description of singletons added * Update singletons.md --------- Co-authored-by: MFransen69 <39826971+MFransen69@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.