Skip to content

Commit

Permalink
feat: Added support to set and get null in ClosedCaptions style fields (
Browse files Browse the repository at this point in the history 
#150)

* feat: Added support to set and get null from ClosedCaptions style fields
  • Loading branch information
@kevinshahfws
kevinshahfws committed Jul 26, 2023
1 parent 1bf056b commit 9c511e4
Show file tree
Hide file tree
Showing 3 changed files with 107 additions and 25 deletions.
6 changes: 4 additions & 2 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

112 changes: 96 additions & 16 deletions src/openrpc/closed_captions.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
]
}
],
"summary": "The prefered font family for displaying closed-captions.",
"summary": "The preferred font family for displaying closed-captions.",
"params": [],
"result": {
"name": "family",
Expand All @@ -83,6 +83,14 @@
"name": "family",
"value": "cursive"
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "family",
"value": null
}
}
]
},
Expand All @@ -99,7 +107,7 @@
]
}
],
"summary": "The prefered font size for displaying closed-captions.",
"summary": "The preferred font size for displaying closed-captions.",
"params": [],
"result": {
"name": "size",
Expand All @@ -123,6 +131,14 @@
"name": "size",
"value": 1
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "size",
"value": null
}
}
]
},
Expand All @@ -139,7 +155,7 @@
]
}
],
"summary": "The prefered font color for displaying closed-captions.",
"summary": "The preferred font color for displaying closed-captions.",
"params": [],
"result": {
"name": "color",
Expand All @@ -163,6 +179,14 @@
"name": "color",
"value": "#000000"
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "color",
"value": null
}
}
]
},
Expand All @@ -179,7 +203,7 @@
]
}
],
"summary": "The prefered font edge style for displaying closed-captions.",
"summary": "The preferred font edge style for displaying closed-captions.",
"params": [],
"result": {
"name": "edge",
Expand All @@ -203,6 +227,14 @@
"name": "edge",
"value": "solid"
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "edge",
"value": null
}
}
]
},
Expand All @@ -219,7 +251,7 @@
]
}
],
"summary": "The prefered font edge color for displaying closed-captions.",
"summary": "The preferred font edge color for displaying closed-captions.",
"params": [],
"result": {
"name": "color",
Expand All @@ -243,6 +275,14 @@
"name": "color",
"value": "#ffffff"
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "color",
"value": null
}
}
]
},
Expand All @@ -259,7 +299,7 @@
]
}
],
"summary": "The prefered opacity for displaying closed-captions characters.",
"summary": "The preferred opacity for displaying closed-captions characters.",
"params": [],
"result": {
"name": "opacity",
Expand All @@ -283,6 +323,14 @@
"name": "opacity",
"value": 100
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "opacity",
"value": null
}
}
]
},
Expand All @@ -299,7 +347,7 @@
]
}
],
"summary": "The prefered background color for displaying closed-captions, .",
"summary": "The preferred background color for displaying closed-captions, .",
"params": [],
"result": {
"name": "color",
Expand All @@ -323,6 +371,14 @@
"name": "color",
"value": "#ffffff"
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "color",
"value": null
}
}
]
},
Expand All @@ -339,7 +395,7 @@
]
}
],
"summary": "The prefered opacity for displaying closed-captions backgrounds.",
"summary": "The preferred opacity for displaying closed-captions backgrounds.",
"params": [],
"result": {
"name": "opacity",
Expand All @@ -363,6 +419,14 @@
"name": "opacity",
"value": 100
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "opacity",
"value": null
}
}
]
},
Expand All @@ -379,10 +443,10 @@
]
}
],
"summary": "The prefered horizontal alignment for displaying closed-captions characters.",
"summary": "The preferred horizontal alignment for displaying closed-captions characters.",
"params": [],
"result": {
"name": "opacity",
"name": "alignment",
"schema": {
"$ref": "https://meta.comcast.com/firebolt/accessibility#/definitions/HorizontalAlignment"
}
Expand All @@ -392,17 +456,25 @@
"name": "Default example #1",
"params": [],
"result": {
"name": "aligment",
"name": "alignment",
"value": "center"
}
},
{
"name": "Default example #2",
"params": [],
"result": {
"name": "aligment",
"name": "alignment",
"value": "left"
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "alignment",
"value": null
}
}
]
},
Expand All @@ -419,10 +491,10 @@
]
}
],
"summary": "The prefered horizontal alignment for displaying closed-captions characters.",
"summary": "The preferred horizontal alignment for displaying closed-captions characters.",
"params": [],
"result": {
"name": "opacity",
"name": "alignment",
"schema": {
"$ref": "https://meta.comcast.com/firebolt/accessibility#/definitions/VerticalAlignment"
}
Expand All @@ -432,17 +504,25 @@
"name": "Default example #1",
"params": [],
"result": {
"name": "alignement",
"name": "alignment",
"value": "middle"
}
},
{
"name": "Default example #2",
"params": [],
"result": {
"name": "alignement",
"name": "alignment",
"value": "top"
}
},
{
"name": "Default example #3",
"params": [],
"result": {
"name": "alignment",
"value": null
}
}
]
}
Expand Down
14 changes: 7 additions & 7 deletions src/schemas/accessibility.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,28 @@
],
"definitions": {
"FontFamily": {
"type": "string"
"type": ["string", "null"]
},
"FontSize": {
"type": "number",
"type": ["number", "null"],
"minimum": 0
},
"FontEdge": {
"type": "string"
"type": ["string", "null"]
},
"Color": {
"type": "string"
"type": ["string", "null"]
},
"Opacity": {
"type": "number",
"type": ["number", "null"],
"minimum": 0,
"maximum": 100
},
"HorizontalAlignment": {
"type": "string"
"type": ["string", "null"]
},
"VerticalAlignment": {
"type": "string"
"type": ["string", "null"]
},
"ClosedCaptionsStyles": {
"title": "ClosedCaptionsStyles",
Expand Down

0 comments on commit 9c511e4

Please sign in to comment.