fix: Errors thrown in async provider methods do not send the JSONRPC …

…error response (#143)
rdkcentral · Nov 1, 2023 · ec8e259 · ec8e259
1 parent 4de8944
commit ec8e259
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/languages/javascript/src/shared/ProvideManager/index.mjs b/languages/javascript/src/shared/ProvideManager/index.mjs
@@ -93,6 +93,18 @@ const provide = function(capability, provider) {
       const response = {
         correlationId: request.correlationId
       }
+      let handleError = error => {
+        response.error = {
+          code: error.code || 1000, // todo: should be some reserved code for "Unknown"
+          message: error.message || `An error occured while calling provided ${method} method.`
+        }
+
+        if (error.data) {
+          response.error.data = JSON.parse(JSON.stringify(error.data))
+        }
+
+        Transport.send(module, `${method}Error`, response)
+      }
 
       try {
         const result = provider[method].apply(provider, providerCallArgs)
@@ -107,19 +119,10 @@ const provide = function(capability, provider) {
           }
 
           Transport.send(module, `${method}Response`, response)
-        })
+        }).catch(err => handleError(err))
       }
       catch(error) {
-        response.error = {
-          code: error.code || 1000, // todo: should be some reserved code for "Unknown"
-          message: error.message || `An error occured while calling provided ${method} method.`
-        }
-
-        if (error.data) {
-          response.error.data = JSON.parse(JSON.stringify(error.data))
-        }
-
-        Transport.send(module, `${method}Error`, response)
+        handleError(error)
       }
     })
   })