DELIA-64891, ES1-1048 : Network failed to connect after Reset (#5139)

* DELIA-64891, ES1-1048 : Network failed to connect after Reset

Reason for change: Avoided posting event when the interface state is empty.
Posting the event only when there is a valid interface state.PSB the details
of the interface state for posting event.
Event name : state
onInterfaceStatusChanged : INTERFACE_REMOVED or INTERFACE_ADDED
onConnectionStatusChanged : INTERFACE_LINK_DOWN or INTERFACE_LINK_UP
Test Procedure: Test and verified with GUI
Risks: Medium
Priority: P1
Signed-off-by: Gururaaja ESR <gururaja_erodesriranganramlingham@comcast.com>

NetworkManager/service/NetworkManager.h

@@ -117,6 +117,8 @@ namespace WPEFramework
                 }
 
             public:
+                /* Only for legacy, we are posting 2 events(onInterfaceStatusChanged and onConnectionStatusChanged) 
+                   in onInterfaceStateChange() function */
                 void onInterfaceStateChange(const Exchange::INetworkManager::InterfaceState event, const string interface) override
                 {
                     NMLOG_TRACE("%s", __FUNCTION__);
@@ -133,15 +135,21 @@ namespace WPEFramework
                         legacyParams["enabled"] = true;
                     else if(event == Exchange::INetworkManager::INTERFACE_REMOVED)
                         legacyParams["enabled"] = false;
-                    _parent.Notify("onInterfaceStatusChanged", legacyParams);
+                    /* Posting the "onInterfaceStatusChanged" event only when the interface state 
+                       is either INTERFACE_REMOVED or INTERFACE_ADDED */
+                    if(event == Exchange::INetworkManager::INTERFACE_REMOVED || event == Exchange::INetworkManager::INTERFACE_ADDED)
+                        _parent.Notify("onInterfaceStatusChanged", legacyParams);
                     if(event == Exchange::INetworkManager::INTERFACE_LINK_UP)
                         onConnParams["status"] = "CONNECTED";
                     else if(event == Exchange::INetworkManager::INTERFACE_LINK_DOWN)
                         onConnParams["status"] = "DISCONNECTED";
                     onConnParams["interface"] = legacyParams["interface"];
                     onConnParams.ToString(json);
                     NMLOG_TRACE("onConnectionStatusChanged onConnParams=%s", json.c_str() );
-                    _parent.Notify("onConnectionStatusChanged", onConnParams);
+                    /* Posting the "onConnectionStatusChanged" event only when the interface state 
+                       is either INTERFACE_LINK_UP or INTERFACE_LINK_DOWN */
+                    if(event == Exchange::INetworkManager::INTERFACE_LINK_UP || event == Exchange::INetworkManager::INTERFACE_LINK_DOWN)
+                        _parent.Notify("onConnectionStatusChanged", onConnParams);
 #endif
                     params["interface"] = interface;
                     params["state"] = InterfaceStateToString(event);

NetworkManager/service/NetworkManagerLegacy.cpp

@@ -41,6 +41,7 @@ namespace WPEFramework
          */
         void NetworkManager::RegisterLegacyMethods()
         {
+            CreateHandler({2});
             Register("getInterfaces",                     &NetworkManager::getInterfaces, this);
             Register("isInterfaceEnabled",                &NetworkManager::isInterfaceEnabled, this);
             Register("getPublicIP",                       &NetworkManager::getPublicIP, this);
@@ -70,6 +71,8 @@ namespace WPEFramework
             Register("saveSSID",                          &NetworkManager::saveSSID, this);
             Register("getSupportedSecurityModes",         &NetworkManager::GetSupportedSecurityModes, this);
             Register("getCurrentState",                   &NetworkManager::GetWifiState, this);
+            GetHandler(2)->Register<JsonObject, JsonObject>("setIPSettings", &NetworkManager::setIPSettings, this);
+            GetHandler(2)->Register<JsonObject, JsonObject>("getIPSettings", &NetworkManager::getIPSettings, this);
         }
 
         /**