RDKDEV-295 ONEM-25358 Split OCDM plugin into 'framework' and 'implementation' parts #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-marcinkowski-red
force-pushed
the
upstream-ocdm-split
branch
from
64df148
to
76eabc6
Compare
piotr-marcinkowski-red
changed the title
mikolaj-staworzynski-red
previously approved these changes
Apr 25, 2022
|
Can one of the admins verify this patch? |
|
@goruklu - Pls review. |
|
Internal JIRA for tracking https://ccp.sys.comcast.net/browse/RDKCOM-2999 |
|
@goruklu and @pradeeptakdas |
…ntation' parts Selected plugins running in out-of-process mode should be split into two separate output libraries where one is a plain implementation run on WPEProcess's end and the other contains the rest of the code that is run on WPEFramework's end This commit splits OCDM plugin - as a result two separate libraries are going to get built - libWPEFrameworkOCDM.so & libWPEFrameworkOCDMImpl.so This change is similar to the one added for WebKitBrowser plugin in this ticket RDKDEV-253 and the following pull request: https://github.com/rdkcentral/rdkservices/pull/2342/files#diff-a4283cefec9f07b7e37bcfe7025517810bc53ecc46d3a44978899fdfbac6648a
piotr-marcinkowski-red
force-pushed
the
upstream-ocdm-split
branch
from
76eabc6
to
5ab16b5
Compare
piotr-marcinkowski-red
changed the title
piotr-marcinkowski-red
changed the title
|
Created RDK Jira ticket for tracking: https://jira.rdkcentral.com/jira/browse/RDKDEV-295 |
|
I'm reviewing this and will provide an update soon |
goruklu
approved these changes
Apr 29, 2022
anand-ky
approved these changes
May 2, 2022
anand-ky
added a commit
that referenced
this pull request
May 16, 2022
RDKDEV-295 ONEM-25358 Split OCDM plugin into 'framework' and 'implementation' parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected plugins running in out-of-process mode should be split into two separate output libraries where
one is a plain implementation run on WPEProcess's end
and the other contains the rest of the code that is run on WPEFramework's end
This commit splits OCDM plugin - as a result two separate libraries are going to get built -
libWPEFrameworkOCDM.so & libWPEFrameworkOCDMImpl.so
This change is similar to the one added for WebKitBrowser plugin in this ticket RDKDEV-253 and
the following pull request:
https://github.com/rdkcentral/rdkservices/pull/2342/files#diff-a4283cefec9f07b7e37bcfe7025517810bc53ecc46d3a44978899fdfbac6648a