Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased rialto plugin rank #83

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Increased rialto plugin rank #83

merged 2 commits into from
Nov 14, 2023

Conversation

aczs
Copy link
Contributor

@aczs aczs commented Nov 14, 2023

Summary: Increase Rialto elements' ranks
Type: Feature
Test Plan: Fullstack tests
Jira: RIALTO-409

Copy link

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

@rdkcmf-jenkins
Copy link

@rdkcmf-jenkins
Copy link

@rdkcmf-jenkins
Copy link

@rdkcmf-jenkins
Copy link

Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 95.7%
Functions coverage stays unchanged and is: 99.7%

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/30517/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/30518/

Copy link
Collaborator

@skyproudmanp skyproudmanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could make it unsigned int (but what you have is probably enough)

@aczs
Copy link
Contributor Author

aczs commented Nov 14, 2023

You could make it unsigned int (but what you have is probably enough)

I tried that and I got overflow in gstreamer as a result. Meaning that I got rank = -1 after I set it to max uint.

@rdkcmf-jenkins
Copy link

@rdkcmf-jenkins
Copy link

@rdkcmf-jenkins
Copy link

@rdkcmf-jenkins
Copy link

Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 95.7%
Functions coverage stays unchanged and is: 99.7%

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/30554/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/30556/

@aczs aczs merged commit 82d8f6d into master Nov 14, 2023
13 checks passed
@aczs aczs deleted the RialtoPluginRankIncrease branch November 14, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants