Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aamp trickplay #87

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Aamp trickplay #87

merged 10 commits into from
Jan 16, 2024

Conversation

skywilliamsonl
Copy link
Collaborator

Summary: Move stop the MediaPlayerManager so that sources can be removed independently.
Type: Fix
Test Plan: Unittests, Aamp trickplay Fullstack.
Jira: RIALTO-431

@github-actions GitHub Actions
Copy link

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/114/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/46861/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/86166/ started.

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/115/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/46862/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/86167/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12310/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12311/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18431/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18432/ started.

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/46864/ started

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/116/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/86168/ started.

@github-actions GitHub Actions
Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 95.3%
Functions coverage stays unchanged and is: 98.7%

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12314/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18433/ started.

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/46865/ started

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/117/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/86170/ started.

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36203/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36204/

@github-actions GitHub Actions
Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 95.3%
Functions coverage stays unchanged and is: 98.7%

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/86171/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12316/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18435/ started.

@github-actions GitHub Actions
Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 95.3%
Functions coverage stays unchanged and is: 98.7%

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36205/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36206/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36207/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36208/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/46931/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/86245/ started.

@github-actions GitHub Actions
Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 95.3%
Functions coverage stays unchanged and is: 98.7%

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12411/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18516/ started.

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36378/

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/122/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36380/

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/132/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/46973/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/86305/ started.

@github-actions GitHub Actions
Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 95.3%
Functions coverage stays unchanged and is: 98.7%

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12472/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18572/ started.

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 Hybrid'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36488/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/36489/

@skywilliamsonl skywilliamsonl merged commit 542bf42 into master Jan 16, 2024
14 checks passed
@skywilliamsonl skywilliamsonl deleted the Aamp_trickplay branch January 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aczs aczs aczs approved these changes

@skyproudmanp skyproudmanp skyproudmanp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@skywilliamsonl @RIALTO-JENKINS-AI @rdkcmf-jenkins @aczs @skyproudmanp