Make unit test coverage decrease more significant #90
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
|
Coverage statistics of your commit: |
|
Job for |
|
Coverage statistics of your commit: |
|
Coverage statistics of your commit: |
|
Coverage statistics of your commit: |
|
Coverage statistics of your commit: |
|
Job for |
|
Coverage statistics of your commit: |
|
Sanity tests for ['RPI4 Hybrid'] added. |
|
Sanity tests for ['RPI4 Hybrid'] added. |
|
Sanity tests for ['RPI4 Hybrid'] added. |
|
Sanity tests for ['RPI4 Hybrid'] added. |
|
Sanity tests for ['RPI4 Hybrid'] added. |
| # Get process_coverage_stats script output | ||
| - id: get-comment-body | ||
| if: ${{ success() && github.ref != 'refs/heads/master' }} | ||
| if: ${{ (success() || failure()) && github.ref != 'refs/heads/master' }} |
There was a problem hiding this comment.
Is that comparison needed? It's always either success or failure
There was a problem hiding this comment.
FYI, I think by default, test steps are skipped if status is failure or cancelled.
There was a problem hiding this comment.
Yup, just tested it out on a different branch and Luke is right, test steps are skipped if the status is failure or cancelled, so both are comparisons are required
| # Create comment with coverage info | ||
| - name: Create Coverage Comment | ||
| if: ${{ success() && github.ref != 'refs/heads/master' }} | ||
| if: ${{ (success() || failure()) && github.ref != 'refs/heads/master' }} |
There was a problem hiding this comment.
Is that comparison needed?
|
Sanity tests for ['BCM Reference Refapp2'] added. |
Summary: Make unit test coverage decrease more significant - rialto-gstreamer
Type: Feature
Test Plan: Unit tests
Jira: RIALTO-421