Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rialto 449 logging change #91

Merged
merged 22 commits into from
Feb 5, 2024
Merged

Rialto 449 logging change #91

merged 22 commits into from
Feb 5, 2024

Conversation

skyproudmanp
Copy link
Collaborator

Summary: RialtoClient's logs output via gstreamer
Type: Feature
Test Plan: run UT & CT and try on UK box
Jira: RIALTO-449

@github-actions GitHub Actions
Copy link

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

@github-actions GitHub Actions
Copy link

source/LogToGstHandler.cpp:31:0: style: The function 'log' is never used. [unusedFunction]

^

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/47084/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12631/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18750/ started.

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/a019df3789cb397b2ffbf1bff4e12c40

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/141/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/47169/ started

@github-actions GitHub Actions
Copy link

source/LogToGstHandler.cpp:49:0: style: The function 'log' is never used. [unusedFunction]

^

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12765/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18829/ started.

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/146/

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/e21bef9b82a3bea4f58bfd42935defde

@github-actions GitHub Actions
Copy link

source/LogToGstHandler.cpp:47:0: style: The function 'log' is never used. [unusedFunction]

^

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/47175/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/12773/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/18856/ started.

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/238b8a6a73edd94e288967d95a7e8078

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/148/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/47196/ started

@github-actions GitHub Actions
Copy link

source/LogToGstHandler.cpp:46:0: style: The function 'log' is never used. [unusedFunction]

^

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/47905/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/47907/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13372/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19752/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13374/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19754/ started.

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/47912/ started

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/dab054e852271d7bc46a312ce6bf370e

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/9a2e058805fbcfb9ecfe2c47b71a9127

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/900c60e343b515ba0f7a6579e04af0f3

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/ba4cd948054e52b453e859019d9a0cbd

skywilliamsonl
skywilliamsonl previously approved these changes Feb 1, 2024
View reviewed changes
@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/194/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/48014/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/48016/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/48018/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13446/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19827/ started.

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/48020/ started

@rdkcmf-jenkins
Copy link

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/d690d3afa09a1dc6f04311d9367a87b1

@RIALTO-JENKINS-AI
Copy link
Collaborator

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/199/

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 94.8% to 94.7%
Functions coverage stays unchanged and is: 98.1%

@skyproudmanp skyproudmanp merged commit 90733f3 into master Feb 5, 2024
9 of 12 checks passed
@skyproudmanp skyproudmanp deleted the rialto_449_logging_change branch February 5, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aczs aczs aczs left review comments

@skywilliamsonl skywilliamsonl skywilliamsonl approved these changes

@skywojciechowskim skywojciechowskim skywojciechowskim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@skyproudmanp @rdkcmf-jenkins @RIALTO-JENKINS-AI @aczs @skywilliamsonl @skywojciechowskim