GCC 13 Integration (#305)

Summary: Compilation fix for g++13, memory leak fix
Type: Fix
Test Plan: UT/CT
Jira: NO-JIRA

CMakeLists.txt

@@ -33,6 +33,10 @@ endif()
 
 add_compile_options(-Wall -Werror)
 
+if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 13.0)
+    add_compile_options(-Wno-error=overloaded-virtual)
+endif()
+
 # By default set link time optimisation, can affect compilation performance
 set(CMAKE_INTERPROCEDURAL_OPTIMIZATION TRUE)
 

media/client/main/source/ClientController.cpp

@@ -21,6 +21,7 @@
 #include "RialtoClientLogging.h"
 #include "SharedMemoryHandle.h"
 #include <cstring>
+#include <stdexcept>
 #include <sys/mman.h>
 #include <sys/un.h>
 #include <unistd.h>

media/client/main/source/MediaPipeline.cpp

@@ -21,6 +21,7 @@
 #include "KeyIdMap.h"
 #include "RialtoClientLogging.h"
 #include <inttypes.h>
+#include <stdexcept>
 #include <stdint.h>
 
 namespace

media/client/main/source/WebAudioPlayer.cpp

@@ -24,6 +24,7 @@
 #include <cstring>
 #include <limits.h>
 #include <mutex>
+#include <stdexcept>
 
 namespace firebolt::rialto
 {

media/server/gstplayer/source/GstGenericPlayer.cpp

@@ -28,6 +28,7 @@
 #include "WorkerThread.h"
 #include "tasks/generic/GenericPlayerTaskFactory.h"
 #include <cinttypes>
+#include <stdexcept>
 
 namespace
 {

media/server/gstplayer/source/GstWebAudioPlayer.cpp

@@ -22,6 +22,7 @@
 #include "RialtoServerLogging.h"
 #include "WorkerThread.h"
 #include "tasks/webAudio/WebAudioPlayerTaskFactory.h"
+#include <stdexcept>
 
 namespace
 {

media/server/gstplayer/source/tasks/generic/AttachSource.cpp

@@ -38,6 +38,7 @@ class MediaSourceCapsBuilder
         : m_gstWrapper(gstWrapper), m_glibWrapper(glibWrapper), m_attachedSource(source)
     {
     }
+    virtual ~MediaSourceCapsBuilder() = default;
     virtual GstCaps *buildCaps() { return buildCommonCaps(); }
 
 protected:
@@ -111,6 +112,7 @@ class MediaSourceAudioCapsBuilder : public MediaSourceCapsBuilder
         : MediaSourceCapsBuilder(gstWrapper, glibWrapper, source), m_attachedAudioSource(source)
     {
     }
+    ~MediaSourceAudioCapsBuilder() override = default;
 
     GstCaps *buildCaps() override
     {
@@ -190,6 +192,7 @@ class MediaSourceVideoCapsBuilder : public MediaSourceCapsBuilder
         : MediaSourceCapsBuilder(gstWrapper, glibWrapper, source), m_attachedVideoSource(source)
     {
     }
+    ~MediaSourceVideoCapsBuilder() override = default;
 
     GstCaps *buildCaps() override
     {
@@ -215,6 +218,7 @@ class MediaSourceVideoDolbyVisionCapsBuilder : public MediaSourceVideoCapsBuilde
         : MediaSourceVideoCapsBuilder(gstWrapper, glibWrapper, source), m_attachedDolbySource(source)
     {
     }
+    ~MediaSourceVideoDolbyVisionCapsBuilder() override = default;
 
     GstCaps *buildCaps() override
     {

media/server/gstplayer/source/tasks/webAudio/SetCaps.cpp

@@ -24,6 +24,7 @@
 
 #include <gst/audio/gstaudiobasesink.h>
 #include <limits.h>
+#include <stdexcept>
 
 namespace firebolt::rialto::server::tasks::webaudio
 {
@@ -37,6 +38,7 @@ class WebAudioCapsBuilder
         : m_gstWrapper(gstWrapper), m_glibWrapper(glibWrapper)
     {
     }
+    virtual ~WebAudioCapsBuilder() = default;
     virtual GstCaps *buildCaps() = 0;
 
 protected:
@@ -53,6 +55,7 @@ class WebAudioPcmCapsBuilder : public WebAudioCapsBuilder
         : WebAudioCapsBuilder(gstWrapper, glibWrapper), m_pcmConfig(pcmConfig)
     {
     }
+    ~WebAudioPcmCapsBuilder() override = default;
 
     GstCaps *buildCaps() override
     {

media/server/ipc/source/IpcFactory.cpp

@@ -44,8 +44,8 @@ std::unique_ptr<ISessionManagementServer>
 IpcFactory::createSessionManagementServer(service::IPlaybackService &playbackService, service::ICdmService &cdmService,
                                           service::IControlService &controlService) const
 {
-    std::shared_ptr<firebolt::rialto::wrappers::ILinuxWrapper> linuxWrapper =
-        std::move(firebolt::rialto::wrappers::ILinuxWrapperFactory::createFactory()->createLinuxWrapper());
+    std::shared_ptr<firebolt::rialto::wrappers::ILinuxWrapper> linuxWrapper{
+        firebolt::rialto::wrappers::ILinuxWrapperFactory::createFactory()->createLinuxWrapper()};
     return std::make_unique<
         SessionManagementServer>(linuxWrapper, firebolt::rialto::ipc::IServerFactory::createFactory(),
                                  firebolt::rialto::server::ipc::IMediaPipelineModuleServiceFactory::createFactory(),

media/server/main/source/ActiveRequests.cpp

@@ -19,6 +19,7 @@
 
 #include "ActiveRequests.h"
 #include <cstring>
+#include <stdexcept>
 
 namespace firebolt::rialto::server
 {

media/server/main/source/MediaPipelineServerInternal.cpp

@@ -18,6 +18,7 @@
  */
 
 #include <algorithm>
+#include <stdexcept>
 
 #include "ActiveRequests.h"
 #include "DataReaderFactory.h"

rialto.supp

@@ -134,3 +134,11 @@
    fun:gst_debug_add_log_function
    ...
 }
+{
+   ignore_protobuf_internal_parse_possibly_lost
+   Memcheck:Leak
+   match-leak-kinds: possible
+   ...
+   fun:*protobuf*FileOptions*_InternalParse*
+   ...
+}

tests/componenttests/server/common/Constants.h

@@ -20,6 +20,7 @@
 #ifndef FIREBOLT_RIALTO_SERVER_CT_CONSTANTS_H_
 #define FIREBOLT_RIALTO_SERVER_CT_CONSTANTS_H_
 
+#include <cstdint>
 #include <string>
 
 #include "MediaCommon.h"

tests/unittests/media/client/main/mediaPipelineCapabilities/MediaPipelineCapabilitiesTest.cpp

@@ -66,7 +66,7 @@ TEST_F(MediaPipelineCapabilitiesTest, createMediaPipelineCapabilitiesIpcFails)
         std::make_shared<StrictMock<MediaPipelineCapabilitiesIpcFactoryMock>>();
 
     EXPECT_CALL(*mediaPipelineCapabilitiesIpcFactoryMock, createMediaPipelineCapabilitiesIpc())
-        .WillOnce(Return(ByMove(std::move(std::unique_ptr<StrictMock<MediaPipelineCapabilitiesIpcMock>>()))));
+        .WillOnce(Return(ByMove(std::unique_ptr<StrictMock<MediaPipelineCapabilitiesIpcMock>>())));
 
     EXPECT_THROW(m_sut = std::make_shared<MediaPipelineCapabilities>(mediaPipelineCapabilitiesIpcFactoryMock),
                  std::runtime_error);

tests/unittests/media/server/gstplayer/genericPlayer/common/GenericTasksTestsBase.cpp

@@ -2191,12 +2191,12 @@ void GenericTasksTestsBase::shouldFlushAudioSrcFailure()
 
 void GenericTasksTestsBase::shouldReadAudioData()
 {
-    EXPECT_CALL(*testContext->m_dataReader, readData()).WillOnce(Invoke([&]() { return std::move(buildAudioSamples()); }));
+    EXPECT_CALL(*testContext->m_dataReader, readData()).WillOnce(Invoke([&]() { return buildAudioSamples(); }));
 }
 
 void GenericTasksTestsBase::shouldReadVideoData()
 {
-    EXPECT_CALL(*testContext->m_dataReader, readData()).WillOnce(Invoke([&]() { return std::move(buildVideoSamples()); }));
+    EXPECT_CALL(*testContext->m_dataReader, readData()).WillOnce(Invoke([&]() { return buildVideoSamples(); }));
 }
 
 void GenericTasksTestsBase::triggerReadShmDataAndAttachSamplesAudio()

tests/unittests/media/server/service/mediaPipelineService/MediaPipelineServiceTestsFixture.cpp

@@ -339,7 +339,7 @@ void MediaPipelineServiceTests::createMediaPipelineShouldSuccess()
 void MediaPipelineServiceTests::createMediaPipelineShouldFailWhenMediaPipelineCapabilitiesFactoryReturnsNullptr()
 {
     EXPECT_CALL(*m_mediaPipelineCapabilitiesFactoryMock, createMediaPipelineCapabilities())
-        .WillOnce(Return(ByMove(std::move(std::unique_ptr<firebolt::rialto::IMediaPipelineCapabilities>()))));
+        .WillOnce(Return(ByMove(std::unique_ptr<firebolt::rialto::IMediaPipelineCapabilities>())));
     EXPECT_THROW(m_sut =
                      std::make_unique<firebolt::rialto::server::service::MediaPipelineService>(m_playbackServiceMock,
                                                                                                m_mediaPipelineFactoryMock,