Register and unregister clients with proxy to fix data race, and tidy the surrounding code #306
Conversation
… call methods on clients that have been freed. The addition of a proxy can prevent this from happening AND remove the need for c style pointers
…ssary inheritance
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
|
Coverage statistics of your commit: |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/705c5c64b9decb383194658a07348009 |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
'['RPI4 IPSTB']' Sanity test FAILURE, investigation pending. |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/1ff62921603cfd6eed3f35d6053aa434 |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
'['RPI4 IPSTB']' Sanity test FAILURE, investigation pending. |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
sanity test failures are most likely unrelated to this change, there are some regressions on rdk-next for RPI currently being investigated, have re-triggered and will up-vote if it fails again |
… instead of iterating through a container
|
Coverage statistics of your commit: |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
|
Coverage statistics of your commit: |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
|
Coverage statistics of your commit: |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
tests/unittests/media/client/main/mediaPipeline/MediaPipelineProxyTest.cpp
Outdated
Show resolved
Hide resolved
…ic header. Restructure proxy tests
|
Coverage statistics of your commit: |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
|
'['BCM 72126OTT Refboard VA']' Sanity test FAILURE, investigation pending. |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
Summary: register and unregister clients (of control) via a proxy (this prevents a data race and updates c style pointers to c++). The call to registerClient in ControlService::addControl was deceiving since this didn't actually register any client... it just called setApplicationState therefore changed to call setApplicationState() direct
Type: Fix
Test Plan: UT/CT and test webaudio on XiOne US box
Jira: NO-JIRA