New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fingerprinting functions should call assignStereochemistry() when necessary #1993
Comments
Hi Brice, |
thanks ! |
* add an additional equality test to testDatastructs (can never have too many tests!) * automatically run assignStereochemistry() for chiral fingerprints This currently runs for the three FP types that support chirality: MFP, AP, and TT
ensure stereochemistry is assigned when calculating fingerprints using chirality (rdkit#1993)
* add FingerprintFuncArguments() to simplify things * getFingerprintHelper() also uses FingerprintFuncArguments * port atompairs and tts to use new code * not working yet * all tests pass * move the includeChirality flag to the global arguments ensure stereochemistry is assigned when calculating fingerprints using chirality (#1993) * migrate legacy morgan fp code to use generators * refactoring the way bit info is handled * all tests pass * all tests pass * expose getArguments() * rename getArguments->getOptions * copyright updates * update a test * remove template from FingerprintArguments some other refactoring and cleanup * hopefully fix the windows dll builds * partial docs update * improve docs and API * more docs * more docs * a bit of modernization * more doc tweaks * changes in response to review
Description:
There seems to be a problem with EnumerateStereoisomers or GetMorganFingerprintAsBitVect and useChirality = True. Below is an example of the issue. I was expecting fp1 and fp2 to be different in the first case. Is it a bug or am I missing something ?
Cheers,
Brice
The text was updated successfully, but these errors were encountered: