Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with -D RDK_BUILD_COORDGEN_SUPPORT=OFF includes a test case that depends on MaeMolSupplier #2929

Closed
rvianello opened this issue Feb 3, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@rvianello
Copy link
Contributor

Configuration:

  • RDKit Version: current tip of the master branch
  • Operating system: Linux (might affect other OSs too)
  • Are you using conda? no

Description:
In file Code/GraphMol/FileParsers/testMolSupplier.cpp, testGitHub2881 I think is missing some conditional compilation directives, so that it's not built when RDK_BUILD_COORDGEN_SUPPORT is disabled.

[ 76%] Building CXX object Code/GraphMol/FileParsers/CMakeFiles/testMolSupplier.dir/testMolSupplier.cpp.o
/opt/RDKit-build/rdkit/Code/GraphMol/FileParsers/testMolSupplier.cpp: In function 'void testGitHub2881()':
/opt/RDKit-build/rdkit/Code/GraphMol/FileParsers/testMolSupplier.cpp:2806:5: error: 'MaeMolSupplier' was not declared in this scope

@greglandrum greglandrum added the bug label Feb 4, 2020
@greglandrum greglandrum added this to the 2019_09_4 milestone Feb 4, 2020
@greglandrum
Copy link
Member

Yep, that was my fault. Thanks for pointing it out.

@greglandrum greglandrum self-assigned this Feb 4, 2020
@rvianello
Copy link
Contributor Author

no problem, sorry I didn't just create a PR, I can do so later today I think (although the fix should be trivial enough to be included into any other changeset).

@greglandrum
Copy link
Member

Na, I'll take care of it. I'm working on an "Ooops" PR anyway; I will do this one at the same time

@rvianello
Copy link
Contributor Author

I see, great, thanks a lot then.

greglandrum added a commit to greglandrum/rdkit that referenced this issue Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants