Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC 10.0.1 compile error #3135

Closed
rvianello opened this issue May 2, 2020 · 0 comments · Fixed by #3146
Closed

GCC 10.0.1 compile error #3135

rvianello opened this issue May 2, 2020 · 0 comments · Fixed by #3146
Labels
bug Cleanup Code cleanup and refactoring
Milestone

Comments

@rvianello
Copy link
Contributor

Configuration:

  • RDKit Version: 2020.03.1, and also the current tip of the master branch
  • Operating system: linux (Fedora 32)
  • Python version (if relevant): not relevant
  • Are you using conda?
  • If you are using conda, which channel did you install the rdkit from?
  • If you are not using conda: how did you install the RDKit?

Description:

The new Fedora 32 release upgrades the default gcc compilers to version 10.0.1. A build of the RDKit C++ libraries fails with the following error:

/Code/GraphMol/catch_sgroups.cpp:210:6: error: could not convert ‘{{{{{{1.0e+0, 3.0e+0, 0.0}}, {{5.0e+0, 7.0e+0, 0.0}}, {{0.0, 0.0, 0.0}}}}, {{{{2.0e+0, 4.0e+0, 0.0}}, {{6.0e+0, 8.0e+0, 0.0}}, {{0.0, 0.0, 0.0}}}}}}’ from ‘<brace-enclosed initializer list>’ to ‘std::vector<std::array<std::array<double, 3>, 3> >’
  210 |     }};
      |      ^
      |      |
      |      <brace-enclosed initializer list>

I'm not sure if it's the proper fix, but, replacing the outermost double braces with single ones, apparently fixes the compile-time error. A similar fix also applies in two locations inside /Code/GraphMol/testSGroup.cpp.

intrigus-lgtm pushed a commit to intrigus-lgtm/rdkit that referenced this issue May 8, 2020
@greglandrum greglandrum added bug Cleanup Code cleanup and refactoring labels May 9, 2020
@greglandrum greglandrum added this to the 2020_03_3 milestone May 9, 2020
greglandrum pushed a commit that referenced this issue May 9, 2020
Co-authored-by: intrigus <abc123zeus@live.de>
greglandrum pushed a commit that referenced this issue Jun 9, 2020
Co-authored-by: intrigus <abc123zeus@live.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Cleanup Code cleanup and refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants