Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw.MolsToGridImage repeating atom indices #3258

Closed
greglandrum opened this issue Jun 26, 2020 · 2 comments
Closed

Draw.MolsToGridImage repeating atom indices #3258

greglandrum opened this issue Jun 26, 2020 · 2 comments
Labels
bug
Milestone
2020_03_4

Comments

@greglandrum
Copy link
Member

Here's a demo:
image

Applies to at least master and 2020.03.3
@greglandrum greglandrum added this to the 2020_03_4 milestone Jun 26, 2020
@DavidACosgrove
Copy link
Collaborator

Mmmm. Off the top of my head, I’d guess that’s not clearing the annotations when it starts preparing the new molecule. It’s cool that it avoids the first set of notes, though😀.
I can look at it over the weekend.

@greglandrum
Copy link
Member Author

I think I have an easy solution. PR coming soon.

greglandrum added a commit to greglandrum/rdkit that referenced this issue Jun 26, 2020
@greglandrum
Fixes rdkit#3258
4f9b8aa
greglandrum added a commit to greglandrum/rdkit that referenced this issue Jun 26, 2020
@greglandrum
test rdkit#3258
781b514
greglandrum added a commit that referenced this issue Jun 28, 2020
@greglandrum
Fixes #3258 (#3259)
fc7b884 
* Fixes #3258

* test #3258

* one additional little test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2020_03_4
Development

No branches or pull requests
2 participants
@greglandrum @DavidACosgrove