Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leak when sanitization fails in InChIToMol() #3655

Closed
greglandrum opened this issue Dec 17, 2020 · 1 comment · Fixed by #3656
Closed

memory leak when sanitization fails in InChIToMol() #3655

greglandrum opened this issue Dec 17, 2020 · 1 comment · Fixed by #3656
Labels
bug
Milestone
2020_09_4

Comments

@greglandrum
Copy link
Member

we aren't cleaning up the memory before throwing the exception
@greglandrum greglandrum added this to the 2020_09_4 milestone Dec 17, 2020
@greglandrum
Copy link
Member Author

discovered while looking into #3645

@greglandrum greglandrum changed the title memory leak with sanitization fails in InChIToMol() memory leak when sanitization fails in InChIToMol() Dec 17, 2020
greglandrum added a commit to greglandrum/rdkit that referenced this issue Dec 17, 2020
@greglandrum
A couple of InChI bug fixes
1d3864f 
Fixes rdkit#3645
Fixes rdkit#3655
@greglandrum greglandrum mentioned this issue Dec 17, 2020
Merged
bp-kelley pushed a commit that referenced this issue Dec 17, 2020
@greglandrum
A couple of InChI bug fixes (#3656)
454abb2 
Fixes #3645
Fixes #3655
greglandrum added a commit that referenced this issue Jan 21, 2021
@greglandrum
A couple of InChI bug fixes (#3656)
9d3db79 
Fixes #3645
Fixes #3655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2020_09_4
Development

Successfully merging a pull request may close this issue.

A couple of InChI bug fixes greglandrum/rdkit
1 participant
@greglandrum