Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDXML Parser does not preserve information about bond wedging #6462

Closed
greglandrum opened this issue Jun 14, 2023 · 0 comments · Fixed by #6463
Closed

CDXML Parser does not preserve information about bond wedging #6462

greglandrum opened this issue Jun 14, 2023 · 0 comments · Fixed by #6463
Labels
Milestone

Comments

@greglandrum
Copy link
Member

Wedged or dashed bonds from mol files have the property _MolFileBondCfg or _MolFileBondStereo set. This allows us to restore the original wedging if desired.
This information is not stored by the CDXML parser, but it should be

Configuration (please complete the following information):

  • RDKit version: release and master
  • OS: all
greglandrum added a commit to greglandrum/rdkit that referenced this issue Jun 14, 2023
greglandrum added a commit that referenced this issue Jun 15, 2023
* Scale bonds, make the Wedge detection cleaner, add more tests

* Readd comment

* Use document bond length

* Adds roundtrip test through a molblock

* a bit of cleanup

* change expected results for a bogus structure
add a non-ambiguous version of it

* fixes #6462

* document incompatibility

---------

Co-authored-by: Brian Kelley <bkelley@relaytx.com>
@greglandrum greglandrum added this to the 2023_03_3 milestone Jun 15, 2023
greglandrum added a commit that referenced this issue Aug 17, 2023
* Scale bonds, make the Wedge detection cleaner, add more tests

* Readd comment

* Use document bond length

* Adds roundtrip test through a molblock

* a bit of cleanup

* change expected results for a bogus structure
add a non-ambiguous version of it

* fixes #6462

* document incompatibility

---------

Co-authored-by: Brian Kelley <bkelley@relaytx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant