Removed RDKIT_SIMDIVPICKERS_EXPORT #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and prevents DLLs from building on Windows
|
@greglandrum tiny fix for building DLLs on Windows. |
bp-kelley
approved these changes
Oct 28, 2019
greglandrum
pushed a commit
that referenced
this pull request
Dec 3, 2019
and prevents DLLs from building on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
RDKIT_SIMDIVPICKERS_EXPORTdirective which should not be there (LeaderPicker.cppis part ofrdSimDivPickersso it should not be imported nor exported) and prevents DLLs from building on Windows.Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?