Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PostgreSQL cartridge install documentation #2870

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Improve PostgreSQL cartridge install documentation #2870

merged 5 commits into from
Jan 9, 2020

Conversation

yellowBirdy
Copy link
Contributor

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

ptosco
ptosco approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@ptosco ptosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only fixed a couple of typos. I am happy to merge.

greglandrum
greglandrum approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that building with the makefile is no longer supported, I don't think those changes are needed, but they don't hurt

@greglandrum greglandrum added this to the 2020_03_1 milestone Jan 9, 2020
@greglandrum greglandrum changed the title PGRdkit install fix Improve PostgreSQL cartridge install documentation Jan 9, 2020
@greglandrum greglandrum merged commit 5e012ab into rdkit:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglandrum greglandrum greglandrum approved these changes

@ptosco ptosco ptosco approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
2020_03_1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yellowBirdy @greglandrum @ptosco