Fix to allow multistructure images in Java/C# and use MCS for c# wrapper #2898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This pull request does two things-
Simple change to the MolDraw.i swig interface so that I can create a ROMol_Ptr_Vect in Java or C# and draw those molecules using MolDraw2DSVG
A change the the csharp_wrapper CMakeLists.txt to use mcs as the mono compiler rather than gmcs (which isn't shipped any more). Without this change it is not possible to create a makefile for building the wrapper.
Any other comments?
The current code base does not compile the c sharp assembly as
PropertyPickleOptions.cs
will not compile. As I don't need that code I can delete that file and compile manually.I'm using dotnet core to build a Linux library. If it's of interest and I could look at replacing mcs with dotnet in CMakeLists.txt.
I've published a Nuget package for dotnet core on Ubuntu built on Rdkit 2019.9 release. We're using it to run dotnet services on Linux containers.