run clang-tidy with readability-braces-around-statements #2899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the discussion of #2877 we talked about making a code formatting change to add braces for all
if
,for
, etc. statements, including one liners. This is that change.Along the way clang-tidy made a few additional mods to the code (using the same settings we used before).
I'm ambivalent about the formatting change and don't think it really adds that much, but I'm not opposed, so if the community think it makes sense, I'll go along. @d-b-w and @bp-kelley: you guys asked for this... think it's worth it?
Other operations here: