New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bogus URFLib library #2900

Merged

bp-kelley merged 3 commits into rdkit:master from greglandrum:fix/urf_build_problems

Jan 28, 2020

Member

greglandrum commented Jan 23, 2020 •

edited

Also includes a couple of other cleanups:

we need to define findRingFamilies() even when we aren't building the URF code.
fixes a typo in the Java wrapper CMakeLists.txt


          a couple of URF building cleanups

55263c8

greglandrum added the bug label

greglandrum added this to the 2019_09_4 milestone

greglandrum added 2 commits

January 23, 2020 16:57


          java wrapper build cleanups

419a943


          no longer need URF.cpp

96a5892

greglandrum changed the title ~~a couple of URF building cleanups~~ Remove bogus URFLib library

Member Author

greglandrum commented Jan 28, 2020

@bp-kelley : I believe that this will help clear up the recent Azure build failures with the win64 DLL builds.
Any objections to me merging this?

bp-kelley merged commit 3851380 into rdkit:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment