Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGroups with more than one attachment point are now properly parsed #3072

Merged
merged 2 commits into from
Apr 12, 2020

Conversation

greglandrum
Copy link
Member

Thanks to Roger S for the example and fix.

@greglandrum greglandrum added the bug label Apr 6, 2020
@greglandrum greglandrum added this to the 2020_03_2 milestone Apr 6, 2020
@greglandrum greglandrum requested a review from ricrogz April 9, 2020 04:56
Copy link
Contributor

@ricrogz ricrogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.

Code/GraphMol/FileParsers/file_parsers_catch.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Ric <ricrogz@users.noreply.github.com>
@greglandrum greglandrum merged commit 60566aa into rdkit:master Apr 12, 2020
@greglandrum greglandrum modified the milestones: 2020_03_2, 2020_03_3 May 15, 2020
@greglandrum greglandrum deleted the dev/roger_sap_patch branch June 9, 2020 13:59
greglandrum added a commit that referenced this pull request Jun 9, 2020
…3072)

* SGroups with more than one attachment point are now properly parsed

Thanks to Roger S for the example and fix.

* Update Code/GraphMol/FileParsers/file_parsers_catch.cpp

Co-Authored-By: Ric <ricrogz@users.noreply.github.com>

Co-authored-by: Ric <ricrogz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants