Python wrapper: SetQuery and ExpandQuery for bonds #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically copied over these two wrappers from Atom.cpp to Bond.cpp.
|
It's "amusing" that the definition of |
|
Relabeling this as a bug because this is fixing an oversight and is risk free for downstream code. |
greglandrum
pushed a commit
that referenced
this pull request
Jun 9, 2020
Basically copied over these two wrappers from Atom.cpp to Bond.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically copied over these two wrappers from Atom.cpp to Bond.cpp.
What does this implement/fix? Explain your changes.
Added the wrappers for completeness / consistency between QueryAtom and QueryBond, and because they'd actually be useful in a program in which I want to modify SMARTS patterns programmatically. (My workaround until now had been to convert to an EditableMol, delete the bond, and add a new bond to replace it. And still isn't as flexible.)