Throw exception when reading from stream fails. #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bp-kelley
requested changes
Jun 7, 2020
|
@intrigus-lgtm, since we are here, should we do the streamWrite as well for symmetry? |
I don't know, but I did it anyway. |
|
I like it, @greglandrum what do you think? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#3211
What does this implement/fix? Explain your changes.
Fixes the problem that the code ignores failures when reading from a stream.
It would also have been possible to explicitly check the status of the stream after each read, but using exceptions seemed easier.
Any other comments?
There are probably other areas that have similar problems.
I only looked at this area, because it currently blocks google/oss-fuzz#3856.
Note, I don't know whether I should have moved the new struct to a different position/file.
Feel free to move it.