-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GetStringVectProp() to SubstanceGroup class #3251
add GetStringVectProp() to SubstanceGroup class #3251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
As an aside: we should come up with a more systematic (and automated) way of adding the
GetXXXProp()
methods to classes in Python.
Yes, that would be interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use boost::python inheritance and add these methods to wrapping for RDProps?
python::class_<SubstanceGroup, boost::shared_ptr<SubstanceGroup>, bases<RDProps>>(
RDProps at one point wasn't a separated class so we haven't wrapped it yet. This is my preferred approach. We do have easy to use templates currently though. the Mol in the names is an artifact. We don't have a template for GetPropNames yet. Make sure you implement GetPropsAsDict, this is a useful function that only lives in python.
|
If this isn't present then the
DATAFIELDS
property of SubstanceGroups cannot be accessed from PythonAs an aside: we should come up with a more systematic (and automated) way of adding the
GetXXXProp()
methods to classes in Python