Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive smarts cannot be used in the core for rgroup decomposition #3404

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Recursive smarts cannot be used in the core for rgroup decomposition #3404

merged 1 commit into from
Sep 11, 2020

Conversation

bp-kelley
Copy link
Contributor

Fixes #3402

greglandrum
greglandrum approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooof, this was a beast to review
;-)

@greglandrum greglandrum added this to the 2020_03_6 milestone Sep 11, 2020
@greglandrum greglandrum changed the title Enable recursive smarts in the rgroup decomposition Recursive smarts cannot be used in the core for the rgroup decomposition Sep 11, 2020
@greglandrum greglandrum changed the title Recursive smarts cannot be used in the core for the rgroup decomposition Recursive smarts cannot be used in the core for rgroup decomposition Sep 11, 2020
@greglandrum greglandrum merged commit 635cfbf into rdkit:master Sep 11, 2020
greglandrum pushed a commit that referenced this pull request Sep 19, 2020
@bp-kelley @greglandrum
Enable recursive smarts in the rgroup decomposition (#3404)
983fdc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglandrum greglandrum greglandrum approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2020_03_6
Development

Successfully merging this pull request may close these issues.

Allow recursive smarts in RGroupDecomposition
2 participants
@bp-kelley @greglandrum