correct handling of amide distances for macrocycles #3559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a patch to the previous PR I submitted for macrocycle conformer generation in order to get the trans preference behaviour when sampling amides in macrocycles.
In the previous PR, I only forced trans configuration of amides when the three consecutive bonds are all ring bonds (in the function
_setMacrocycleAllInSameRing14Bounds
).However, another enforcing is needed when faced with two consecutive ring bonds(in the function
_setMacrocycleTwoInSameRing14Bounds
), which was included during my code development and I (carelessly) neglected to add in that PR.This PR adds two more variants of the
checkAmideEster14
, please see illustration in the comment section above each of the two functions to understand the need for them.In addition I also included:
useMacrocycle14config
) when getting the bounds matrix of a molecule, which is needed when trying to set custom bounds matrix in order to bias sampling of macrocycles with amides