Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct handling of amide distances for macrocycles #3559

Merged
merged 2 commits into from
Nov 24, 2020
Merged

correct handling of amide distances for macrocycles #3559

merged 2 commits into from
Nov 24, 2020

Conversation

hjuinj
Copy link
Contributor

@hjuinj hjuinj commented Nov 9, 2020

This PR is a patch to the previous PR I submitted for macrocycle conformer generation in order to get the trans preference behaviour when sampling amides in macrocycles.

In the previous PR, I only forced trans configuration of amides when the three consecutive bonds are all ring bonds (in the function _setMacrocycleAllInSameRing14Bounds).

However, another enforcing is needed when faced with two consecutive ring bonds(in the function _setMacrocycleTwoInSameRing14Bounds), which was included during my code development and I (carelessly) neglected to add in that PR.

This PR adds two more variants of the checkAmideEster14, please see illustration in the comment section above each of the two functions to understand the need for them.

In addition I also included:

  • a test case for checking trans amide sampling when using macrocycle conformer generation (ETKDGv3)
  • additional argument (useMacrocycle14config) when getting the bounds matrix of a molecule, which is needed when trying to set custom bounds matrix in order to bias sampling of macrocycles with amides

@greglandrum
Copy link
Member

@sriniker : have you looked through (and approved) this already? Knowing that you have would save me a lot of effort. :-)

@sriniker
Copy link
Contributor

@greglandrum: Yes, Shuzhe and I have discussed the implementation and gone through the code together.

@greglandrum greglandrum merged commit 666df68 into rdkit:master Nov 24, 2020
@greglandrum greglandrum added this to the 2020_09_2 milestone Nov 24, 2020
@greglandrum
Copy link
Member

Thanks @hjuinj !

greglandrum pushed a commit that referenced this pull request Nov 24, 2020
* patch correct handling of amide distances for macrocycles

* higher delta for test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants