Bump catch2 version to allow builds on Apple M1 #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglandrum
changed the title
greglandrum
changed the title
|
@naefl Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates catch2 version which caused the build on Apple's M1 to fail
Any other comments?
Generally, builds run fine, I've both built against the official Python 3.9 with universal binaries which was just released, miniforge's python3.9 and a miniforge's 3.8 environments.
For people trying to build this on the M1 I would recommend getting all binary dependencies with miniforge.
Code signing caused issues as well - unfortunately the fix suggested in the rdkit docs didn't work so I had to sign all
.dylibsusing an actual apple developer account (codesign -f -s "<yourid>" $HOME/miniconda3/lib/*/*.so)