Check PIL support for tostring and fromstring #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code checks whether the methods tostring and fromstring exist in a PIL image object like this: getattr(image, 'tobytes', image.tostring) This code raises an exception when image doesn't have the tostring method. That seems to be the case in recent pillow versions! Check if the tostring or tobytes method exists (in this order). This is related to rdkit#644.
greglandrum
approved these changes
Jan 15, 2021
|
Thanks for the fix @sirbiscuit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code checks whether the methods tostring and fromstring
exist in a PIL image object like this:
getattr(image, 'tobytes', image.tostring)
This code raises an exception when image doesn't have the tostring
method. That seems to be the case in recent pillow versions!
Check if the tostring or tobytes method exists (in this order).
This is related to #644.
Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?