Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to add ZLIB_INCLUDE_DIRS for Windows build #3714

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Fix to add ZLIB_INCLUDE_DIRS for Windows build #3714

merged 1 commit into from
Jan 15, 2021

Conversation

k-ujihara
Copy link
Contributor

This PR further fixes issue #3494, which is fixed by PR #3493. zlib.h is required on the following line even if boost_zlib is found.

rdkit/Code/GraphMol/FileParsers/PNGParser.cpp

Line 25 in 46a0af8

#include <zlib.h>

@greglandrum greglandrum added this to the 2021_03_1 milestone Jan 15, 2021
@greglandrum greglandrum added the infrastructure build infrastructure and the like label Jan 15, 2021
@greglandrum greglandrum merged commit 759b7a4 into rdkit:master Jan 15, 2021
@greglandrum
Copy link
Member

Thanks @kazuyaujihara !

@k-ujihara k-ujihara deleted the patch/win_zlib_build branch January 16, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug infrastructure build infrastructure and the like
Projects
None yet
Milestone
2021_03_1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-ujihara @greglandrum