Added SDF Export to PandasTools and adjusted SDF Import #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request contains the commit from @samoturk in the pull request #401. In addition to these changes, I made the generation of a smiles column optional and defaulting to not generate it. Adding a smiles column later on is simple, but automatically doing it silently changes the matching of SD tags to dataframe columns.
The export is fairly self contained and is nearly identically reproducing the SDF input. The deviations are mainly occuring when some SD tags are not present in all molecules in the input SDF. Such cells are filled in the dataframe with "nans" which consequently end up in the written SDF.
Another deviation is that the generated SD file contains the valences for some atoms (e.g. Cu,Si,Se) in the atoms block even if they were not present in the input.
Are these deviations acceptable?
@samoturk : Do you think the method signatures and the changes to the input are reasonable or would you suggest doing things differently?