Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow more recoverable V3000 parsing errors when strictParsing=false #4210

Merged
merged 1 commit into from
Jun 7, 2021
Merged

allow more recoverable V3000 parsing errors when strictParsing=false #4210

merged 1 commit into from
Jun 7, 2021

Conversation

greglandrum
Copy link
Member

Allows a couple of additional problems with v3000 mol files to be ignored when strictParsing=false:

  • missing SGroup section
  • mssing END SGROUP
  • missing BEGIN/END OBJ3D (no tests for this, but we don't have any tests for OBJ3D anyway)

Additionally: if there aren't enough SGroups we'll now generate an error unless strictParsing is false

@greglandrum greglandrum added the bug label Jun 5, 2021
@greglandrum greglandrum added this to the 2021_03_3 milestone Jun 5, 2021
@greglandrum greglandrum requested a review from ricrogz June 5, 2021 08:42
@greglandrum
Copy link
Member Author

@ricrogz , @d-b-w : this should resolve SHARED-7892

ricrogz
ricrogz approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@ricrogz ricrogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@greglandrum greglandrum merged commit 5d0eb77 into rdkit:master Jun 7, 2021
@greglandrum greglandrum deleted the fix/strictParsing_sgroups branch June 7, 2021 13:39
@greglandrum greglandrum modified the milestones: 2021_03_3, 2021_03_4 Jun 22, 2021
greglandrum added a commit that referenced this pull request Jul 9, 2021
@greglandrum
allow more recoverable SGroup errors when strictParsing=false (#4210)
5b73a2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricrogz ricrogz ricrogz approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2021_03_4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greglandrum @ricrogz