Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGD: Fix memory leak with deleting array #4211

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

bp-kelley
Copy link
Contributor

Fixes delete called on array

Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one.
did you run valgrind across the RGD code?

@greglandrum greglandrum added the bug label Jun 8, 2021
@greglandrum greglandrum added this to the 2021_03_3 milestone Jun 8, 2021
@greglandrum greglandrum merged commit 8d4b5cb into rdkit:master Jun 8, 2021
@greglandrum greglandrum changed the title Fix memory leak with deleting array RGD: Fix memory leak with deleting array Jun 8, 2021
@bp-kelley bp-kelley deleted the fix/rgroupcore-delete branch June 8, 2021 13:36
@bp-kelley
Copy link
Contributor Author

@greglandrum the Xcode analyzer actually found this one, I caught it by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants