clean up some leaks identified by an ASAN build #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-kwsm
reviewed
Jul 23, 2021
Code/GraphMol/MolStandardize/TautomerCatalog/TautomerCatalogUtils.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
bp-kelley
reviewed
Jul 27, 2021
| @@ -35,7 +35,7 @@ class TautomerCatalogParams; | |||
| // typedef std::vector<ROMol*, std::string, std::string> tautomerTransform; | |||
| class RDKIT_MOLSTANDARDIZE_EXPORT TautomerTransform { | |||
| public: | |||
| ROMol* Mol; | |||
| ROMol* Mol = nullptr; | |||
There was a problem hiding this comment.
Could just make this a unique_ptr
There was a problem hiding this comment.
yeah, we could, but that's a public API change (not necessarily tragic here because probably no one is using that public data member)
Is the benefit of that important enough to change the API?
|
@bp-kelley : ok to merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few memory leaks identified by running the C++ tests in an ASAN build