fix a thread-safety bug in the UFF parameter loading #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptosco : this one is pretty short, would you mind reviewing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were using the singleton here was, I think, not particularly threadsafe. This might have been leading to a Heisenbug in the KNIME nodes.
The changes here outsource worrying about thread-safe initialization to boost::flyweight (yay!).
I didn't add any new tests because we're already doing current multi-threaded UFF and conformer generation (this also uses UFF parameters) tests. Those weren't showing any problem and I didn't manage to come up with anything that would reproducibly show the problem.