Fix some problems turned up by ossfuzz #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I like the dynamic_cast here, I was always a bit queasy about the static casts. Some of these look like API changes, does there need to be a change list for these? |
None of the changes should break existing code. We lose ABI compatibility (so a recompile will be required), but that's not something I even try to maintain. It is a good point that with changes to the API like this it probably shouldn't be part of a patch release. I'll change the milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the results of some of the more serious fuzz test failures led to this series of fixes.
Some of these are for undefined behavior (mainly due to static_casting the wrong way in the type hierarchy), but some are general defensive programming when it comes to parsing inputs. Most of the defensive programming stuff won't matter with real inputs, but it doesn't hurt to tighten up the parsers some.