Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra newline from Kekulize error message. #5022

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

xavierholt
Copy link
Contributor

The log message for a Kekulization failure had an extra newline. This removes it.

Example of the old behavior:

[01:01:51] Can't kekulize mol.  Unkekulized atoms: 6 7 8 9 10

[01:01:51] Explicit valence for atom # 2 H, 2, is greater than permitted
[01:01:51] Explicit valence for atom # 2 H, 2, is greater than permitted
[01:01:51] Explicit valence for atom # 2 H, 2, is greater than permitted
[01:01:51] Can't kekulize mol.  Unkekulized atoms: 17 18 19 21 22

[01:01:51] Explicit valence for atom # 2 H, 2, is greater than permitted
[01:01:51] Can't kekulize mol.  Unkekulized atoms: 8 10 12 15 18

Copy link
Member

@greglandrum greglandrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xavierholt!

@greglandrum greglandrum added this to the 2021_09_5 milestone Feb 22, 2022
@greglandrum greglandrum merged commit 7bd9f7b into rdkit:master Feb 22, 2022
greglandrum pushed a commit that referenced this pull request Mar 5, 2022
* Remove extra newline from Kekulize error message.

* Fix test for exception message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants