Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mol drawing on Python3 (issue #460) #504

Merged
merged 1 commit into from
May 16, 2015
Merged

Fix mol drawing on Python3 (issue #460) #504

merged 1 commit into from
May 16, 2015

Conversation

apahl
Copy link
Contributor

@apahl apahl commented May 7, 2015

@apahl
* cairocffi aims at being a drop-in replacement for cairo but does no…
2a5eee4 
…t seem to be quite there, yet

* this hack fixes issue #460 by trying to use cairocffi when running on Python3 and cairo when running on Python2
* tested for both Python versions
greglandrum added a commit that referenced this pull request May 16, 2015
@greglandrum
Merge pull request #504 from apahl/py3_cairo
f0bcb45 
Fix mol drawing on Python3 (issue #460)
@greglandrum greglandrum merged commit f0bcb45 into rdkit:master May 16, 2015
@greglandrum
Copy link
Member

Thanks Axel.

@greglandrum greglandrum added this to the 2015_09_1 milestone May 16, 2015
greglandrum added a commit that referenced this pull request May 16, 2015
@greglandrum
patch to make #504 work with python 2
99bd9cc
@apahl apahl deleted the py3_cairo branch May 17, 2015 15:51
sriniker pushed a commit to sriniker/rdkit that referenced this pull request Oct 20, 2015
@greglandrum
patch to make rdkit#504 work with python 2
0dde0ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2015_09_1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apahl @greglandrum